Fix: Improve transactional safety of payload offload reads and writes

[mrkaye97]

Description

Makes the payload offload job a little bit more transactionally safe by listing doing the original payload listing + the writes in separate txs

Type of change

• Bug fix (non-breaking change which fixes an issue)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
hatchet-docs	Ready	Preview, Comment	May 4, 2026 5:06pm

[Copilot]

Pull request overview

This PR aims to improve transactional safety during payload cutover/offload batches by opening a single transaction earlier and reusing it through window-size optimization, range chunk creation, payload reads, and the final temp-table insert + lease update.

Changes:

• Start a DB transaction at the beginning of each cutover batch iteration (payloadstore + OLAP).
• Thread the transaction through the window-size optimization and payload range chunk creation queries.
• Switch paginated payload reads to use the same transaction connection instead of the pool.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
pkg/repository/payloadstore.go	Opens a long-running tx for ProcessPayloadCutoverBatch and passes it into sizing/chunking/listing queries.
pkg/repository/olap.go	Same pattern as payloadstore for OLAP payload cutover batches.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (2)

pkg/repository/payloadstore.go:662

• This function now uses two separate transactions but reuses the same tx/commit/rollback variables and stacks multiple defer rollback() calls. It works, but it’s easy to misread/modify incorrectly later. Consider scoping each transaction in its own block and/or using distinct variable names so it’s obvious which rollback/commit corresponds to which transaction.

	tx, commit, rollback, err = sqlchelpers.PrepareTx(ctx, p.pool, p.l)

	if err != nil {
		return nil, fmt.Errorf("failed to prepare transaction for copying offloaded payloads: %w", err)
	}

	defer rollback()

pkg/repository/olap.go:3130

• Similar to payloadstore, this function now uses multiple transactions but reuses tx/commit/rollback and defers multiple rollbacks in the same scope. To reduce the chance of future mistakes, consider scoping each transaction in its own block or using distinct variable names for each transaction.

	tx, commit, rollback, err = sqlchelpers.PrepareTx(ctx, p.pool, p.l)

	if err != nil {
		return nil, fmt.Errorf("failed to prepare transaction for copying offloaded payloads: %w", err)
	}

	defer rollback()