Skip to content

Fix: Improve performance of status metrics query #3800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrkaye97 merged 1 commit into from
May 5, 2026
+18 −0
Merged

Fix: Improve performance of status metrics query #3800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pkg/repository/sqlcv1/olap.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1416,7 +1416,16 @@ WITH task_external_ids AS (
) AS u ON kv.key = u.k AND kv.value = u.v
)
)
AND tenant_id = @tenantId::UUID
AND inserted_at >= @createdAfter::TIMESTAMPTZ
Copy link
Copy Markdown
Contributor

@grutt grutt May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isnt breaking?

Copy link
Copy Markdown
Contributor Author

@mrkaye97 mrkaye97 May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't think so, why would it be?

Copy link
Copy Markdown
Contributor

@grutt grutt May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my fault, missed that we already had created after later in the query

Copy link
Copy Markdown
Contributor Author

@mrkaye97 mrkaye97 May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good!

AND (
sqlc.narg('createdBefore')::TIMESTAMPTZ IS NULL OR inserted_at <= sqlc.narg('createdBefore')::TIMESTAMPTZ
)
AND (
sqlc.narg('workflowIds')::UUID[] IS NULL OR workflow_id = ANY(sqlc.narg('workflowIds')::UUID[])
)
)

SELECT
tenant_id,
COUNT(*) FILTER (WHERE readable_status = 'QUEUED') AS total_queued,
Expand Down
9 changes: 9 additions & 0 deletions pkg/repository/sqlcv1/olap.sql.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading