fix: docs search hidden pages#3734
Open
dhimanAbhi wants to merge 1 commit intohatchet-dev:mainfrom
Open
Conversation
Signed-off-by: Abhishek Dhiman <abhi2002dhiman@gmail.com>
|
@dhimanAbhi is attempting to deploy a commit to the Hatchet Team on Vercel. A member of the Team first needs to authorize it. |
gregfurman
requested changes
May 4, 2026
Collaborator
gregfurman
left a comment
gregfurman
left a comment
There was a problem hiding this comment.
Thanks for the contribution! Can we tidy up the diff a bit so these changes are minimal?
Comment on lines
+324
to
+329
| console.log("SEARCH DEBUG:", { | ||
| query, | ||
| raw: raw.map(r => ({ id: r.id, hidden: r.hidden })), | ||
| reranked: reranked.map(r => ({ id: r.id, hidden: r.hidden })), | ||
| visible: visibleResults.map(r => ({ id: r.id, hidden: r.hidden })), | ||
| }); |
Collaborator
There was a problem hiding this comment.
🧹 This seems like it could get spammy very quickly
Suggested change
| console.log("SEARCH DEBUG:", { | |
| query, | |
| raw: raw.map(r => ({ id: r.id, hidden: r.hidden })), | |
| reranked: reranked.map(r => ({ id: r.id, hidden: r.hidden })), | |
| visible: visibleResults.map(r => ({ id: r.id, hidden: r.hidden })), | |
| }); |
| try { | ||
| const expanded = expandSynonyms(query); | ||
| const raw = idx.search(expanded, SEARCH_OPTIONS); | ||
| // Rerank against the original query so title matching is accurate |
Collaborator
There was a problem hiding this comment.
Can we preserve these comments?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hidden documentation pages marked with
display: "hidden"in_meta.jswere appearing in search results.This PR fixes the issue by ensuring that hidden pages are excluded from the search UI while still being included in the search index for MCP compatibility.
Fixes #3146
Type of change
What's Changed
hiddenflag to search index entries during generation_meta.jsacross nested pages