[Fix #507] New Load Modes for upfront loading of cradle/project#508
[Fix #507] New Load Modes for upfront loading of cradle/project#508Saizan wants to merge 12 commits into
Conversation
|
|
||
| -- leftovers contains all Targets from the command line | ||
| let leftovers = map G.unLoc leftovers' ++ additionalTargets | ||
| let leftovers = filter (/= "-unit") (map G.unLoc leftovers') ++ additionalTargets |
There was a problem hiding this comment.
@fendor does it make sense that I'd have to filter "-unit" here? Or am I doing something wrong?
There was a problem hiding this comment.
I don't know why you should have to filter the -unit flags out here, that looks incorrect.
We didn't have to do this before, iirc.
There was a problem hiding this comment.
Turns out that initSession/addCmdOpts are not setup to handle multiple home units, i guess we should update them? are they used in hls?
There was a problem hiding this comment.
No, I think we are using them only for tests these days.
EDIT: addCmdOpts is still used in HLS for initialising a single home unit.
There was a problem hiding this comment.
I left addCmdOpts alone. initSession' now uses addCmdOpts if there is no -unit flag, and initMulti otherwise
2 participants
PR for #507