frontend request is made by filtering taskID instead of taskWrapperId#707
Open
LuffyNoNika wants to merge 2 commits into
Open
frontend request is made by filtering taskID instead of taskWrapperId#707LuffyNoNika wants to merge 2 commits into
LuffyNoNika wants to merge 2 commits into
Conversation
Contributor
|
@LuffyNoNika Changing the dataKey here to 'taskId' from 'taskWrapperId' will also affect the sort field in addition to the searchable text input. |
Contributor
|
Switched filter locally in the task table to taskId if column is ID. Localized change as alternative would have been to add a config field to the table config in order to specify the filter key specifically which would have affected a large number of tables. In order to keep the changes small for the 1.0 release it was done this way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Id filter for tasks now filters correctly.