Fix encode path hyphen - #384
Merged
Merged
Conversation
Fix `encode_path` whitelist to exclude '-' from encoding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #350
Closes #343
The encode_path method in lib/vault/encode.rb incorrectly encodes the hyphen (-) character, causing 403 permission denied errors when accessing paths like /auth/token/lookup-self on modern Vault servers (1.15+).
Cause: The regex
[^a-zA-Z0-9_.-/]has an unescaped hyphen inside the character class. In Ruby regex, an unescaped hyphen between characters defines a range (e.g.,.-/means "characters from . to /"), not the literal characters ., -, and /.The hyphen gets URL-encoded to %2D, which newer Vault versions don't decode before checking permissions.
Cherry picked a PR'd solution to this with attribution, I just added some tests and changelog entries.