Skip to content

Replace deprecated JSON.fast_generate - #349

Merged
chrisarcand merged 1 commit into
hashicorp:masterfrom
nevans:json-deprecated-fast_generate
Dec 3, 2025
Merged

Replace deprecated JSON.fast_generate#349
chrisarcand merged 1 commit into
hashicorp:masterfrom
nevans:json-deprecated-fast_generate

Conversation

@nevans

@nevans nevans commented Sep 8, 2025

Copy link
Copy Markdown
Contributor

JSON.fast_generate is deprecated and will be removed in json 3.0.0, just use JSON.generate.

@nevans
nevans requested a review from a team as a code owner September 8, 2025 17:37
@nevans

nevans commented Nov 21, 2025

Copy link
Copy Markdown
Contributor Author

@chrisarcand @brandonc Sorry to ping you on this. I just noticed that vault-rails recently had its first update in a long time. And this gem is in serious need of maintenance, for compatibility with modern ruby versions. Without this change, modern versions of the json gem (which are packaged with modern versions of ruby) will print an enormous number of deprecation warnings.

`JSON.fast_generate` is deprecated and will be removed in json 3.0.0, just
use `JSON.generate`.
@chrisarcand
chrisarcand force-pushed the json-deprecated-fast_generate branch from 21af1cc to 8c8cc6b Compare December 3, 2025 18:42
@chrisarcand
chrisarcand requested a review from a team as a code owner December 3, 2025 18:42
@chrisarcand
chrisarcand merged commit f596b69 into hashicorp:master Dec 3, 2025
18 checks passed
@nevans
nevans deleted the json-deprecated-fast_generate branch December 5, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants