Skip to content

Fix RekeyAttempt Types - #252

Open
SEANDOUGHTY wants to merge 4 commits into
hashicorp:mainfrom
renderinc:sean/rekey-attempt-types
Open

Fix RekeyAttempt Types#252
SEANDOUGHTY wants to merge 4 commits into
hashicorp:mainfrom
renderinc:sean/rekey-attempt-types

Conversation

@SEANDOUGHTY

@SEANDOUGHTY SEANDOUGHTY commented Feb 15, 2024

Copy link
Copy Markdown

Description

  1. The type of started in a rekey attempt should be boolean instead of string
  2. Nounce should be nonce

Resolves # (issue)

This resolves: #251

@SEANDOUGHTY
SEANDOUGHTY requested a review from a team as a code owner February 15, 2024 00:16
@hashicorp-cla

hashicorp-cla commented Feb 15, 2024

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@SEANDOUGHTY SEANDOUGHTY changed the title change RekeyAttempt started type from string to bool Fix RekeyAttempt Types Feb 15, 2024
@dhuckins
dhuckins requested a review from averche February 15, 2024 15:22
@averche

averche commented Feb 19, 2024

Copy link
Copy Markdown
Collaborator

Thank you for contributing to the library, @SEANDOUGHTY!

The openapi.json file in this repo is generated from Vault server using gen_openapi.sh so the problem needs to be addressed there first.

I've put together a small PR (hashicorp/vault#25509) to address this at the source. Once merged, I'll regenerate openapi.json and push it here as well :)

@SEANDOUGHTY

Copy link
Copy Markdown
Author

Thank you for contributing to the library, @SEANDOUGHTY!

The openapi.json file in this repo is generated from Vault server using gen_openapi.sh so the problem needs to be addressed there first.

I've put together a small PR (hashicorp/vault#25509) to address this at the source. Once merged, I'll regenerate openapi.json and push it here as well :)

Sounds good! It looks like that PR just got approved 💯

@SEANDOUGHTY

Copy link
Copy Markdown
Author

Can we complete this PR now?

@averche

averche commented Mar 6, 2024

Copy link
Copy Markdown
Collaborator

Can we complete this PR now?

Sorry, it's been busy couple of weeks, I will take care of it this week.

@SEANDOUGHTY

Copy link
Copy Markdown
Author

@averche any update on getting this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot unmarshal into Go struct RekeyAttemptReadProgressResponse

3 participants