add the before_start_hook#251
Draft
rgl wants to merge 1 commit into
Draft
Conversation
this will executed after the vm is configured, but before its started this receives the vm configuration as a json in stdin the hook is expected to return a json with the modified configuration
13e4a71 to
9957253
Compare
|
It seems to me this is a bit of a kludge. |
Contributor
Author
|
@rhpijnacker-philips yes, like described at #198, this is an escape hatch, to use in those cases where there is no other way. |
|
i am desperate for this! very excited as i'd like to automate mac deployment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a PoC for #198.
I'm looking for suggestions about the name of the configuration property, currently, its called
before_start_hook.if you agree with this change, I'll later will be adding the missing documentation.
the
before_start_hookconfiguration setting contains the command that will be executed after the vm is configured, but before its started.the command receives the current vm configuration as a json in its stdin
the hook command is expected to return a json with the modified configuration, typically, this document should only contain the properties that you want to actually modify.
the following example is modifying the
ide0andide1media fromcdromtodisk, something that is useful when we have a disk image instead of an iso:Closes #198