allocs rpc: fix client panic on nil allocs#28187
Merged
Merged
Conversation
A client can panic on a nil alloc sent by the server if the alloc gets GC'd at an innoportune moment, namely between two distinct RPC calls in the same loop. The server should never return a nil alloc. Instead, return a partial slice that is shorter than the number of allocs requested. Note: At this time, the client does not make use of the partial list; it simply discards the results and retries in a couple seconds (client/client.go line 2683). Potential client optimizations may be revisited as a follow-up.
tgross
approved these changes
Jun 26, 2026
tgross
left a comment
Member
There was a problem hiding this comment.
LGTM!
Note: At this time, the client does not make use of the partial list; it simply discards the results and retries in a couple seconds (client/client.go line 2683). Potential client optimizations may be revisited as a follow-up.
Well-worded 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A client can panic on a nil alloc sent by the server if the alloc gets GC'd at an innoportune moment, namely between two distinct RPC calls in the same loop.
The server should never return a nil alloc. Instead, return a partial slice that is shorter than the number of allocs requested.
Fixes: #28172
Note: At this time, the client does not make use of the partial list; it simply discards the results and retries in a couple seconds (client/client.go line 2683). Potential client optimizations may be revisited as a follow-up.
Testing
Server-side unit tests ensures no
nilallocs in the response. I'll explore Client-side tests, but it'll take some extra doing to set up mocks for the RPC calls.Contributor Checklist
changelog entry using the
make clcommand.ensure regressions will be caught.
and job configuration, please update the Nomad product documentation, which is stored in the
web-unified-docsrepo. Refer to theweb-unified-docscontributor guide for docs guidelines.Please also consider whether the change requires notes within the upgrade
guide. If you would like help with the docs, tag the
nomad-docsteam in this PR.and followed the AI usage guide.
Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.