ui: NMD-872-System jobs on node-pools scaled to 0 show up in UI as failed#27949
Open
navyadas-dev wants to merge 2 commits into
Open
ui: NMD-872-System jobs on node-pools scaled to 0 show up in UI as failed#27949navyadas-dev wants to merge 2 commits into
navyadas-dev wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
System jobs with no eligible nodes (e.g., when all nodes in a node pool are scaled to zero, or when constraints don't match any nodes) incorrectly display as "Failed" in both the jobs list and job details page. This is misleading because the job hasn't actually failed - it simply has no nodes to run on.
Reproduction Steps
I have used constraints instead of node pools as Node Pools Governance is an enterprise feature.
Changes:
ui/app/models/job.js (Jobs List Status)ui/app/components/job-status/panel/steady.js(Job Details Page Status)ui/tests/acceptance/jobs-list-test.js(Test Update)Testing & Reproduction steps
Before:
System job with no eligible nodes: "Failed" (red)
NMD-872-Before.mov
After:
System job with no eligible nodes: "Scaled Down" (neutral/gray)
NMD-872-After.mov
Job List view

Job details page

Links
https://hashicorp.atlassian.net/browse/NMD-872
Contributor Checklist
changelog entry using the
make clcommand.ensure regressions will be caught.
and job configuration, please update the Nomad product documentation, which is stored in the
web-unified-docsrepo. Refer to theweb-unified-docscontributor guide for docs guidelines.Please also consider whether the change requires notes within the upgrade
guide. If you would like help with the docs, tag the
nomad-docsteam in this PR.Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.