Fix sending compound messages corruption when including messages larger than 64KB (PR #260 clone)#262
Open
alvinlin123 wants to merge 4 commits into
Open
Fix sending compound messages corruption when including messages larger than 64KB (PR #260 clone)#262alvinlin123 wants to merge 4 commits into
alvinlin123 wants to merge 4 commits into
Conversation
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
|
|
|
Thanks for this @alvinlin123 We'll try to carve out some time to get this reviewed. Unfortunately the original reviewer is no longer working at Hashicorp so i'll need to pull in a quick second pair of eyes. Since this is just the revisions it won't be a full re-review |
Author
|
@Amier3 any luck finding someone to review? |
Author
|
@Amier3 any news ? |
|
@Amier3 were you about to find someone to review this? |
|
any update on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am cloning PR #260 to address the review comments because original author of PR #260 doesn't seem to have time to address the review comments.