Skip to content

CI: update checks and copywrite config#153

Merged
tgross merged 1 commit into
mainfrom
ci-update
Jun 11, 2026
Merged

CI: update checks and copywrite config#153
tgross merged 1 commit into
mainfrom
ci-update

Conversation

@tgross

@tgross tgross commented Jun 11, 2026

Copy link
Copy Markdown
Member

Update CI so that we're checking and testing against the current stable and the previous stable. Run golangci-lint with current config and address the issues there. Add copywrite config and ensure it runs on every PR. Tidy up the makefile.

This should incidentally clear all the remaining CodeQL noise as well.

Ref: https://hashicorp.atlassian.net/browse/NMD-1566

@tgross tgross force-pushed the ci-update branch 2 times, most recently from 0c078b1 to e2e128e Compare June 11, 2026 17:20
@tgross tgross marked this pull request as ready for review June 11, 2026 17:25
@tgross tgross requested review from a team as code owners June 11, 2026 17:25
@tgross tgross requested review from gulducat, jrasell and tehut June 11, 2026 17:25
@tgross

tgross commented Jun 11, 2026

Copy link
Copy Markdown
Member Author

GitHub Actions appears to be having a normal one, but:

$ make lint
golangci-lint run
0 issues.

$ make test
go test -v -race -timeout=60s -parallel=10 ./...
=== RUN   TestServer_StartStop
--- PASS: TestServer_StartStop (0.00s)
=== RUN   TestServer_Lookup
2026/06/11 13:25:37 [INFO] mdns: Failed to listen to both unicast and multicast on IPv6
--- PASS: TestServer_Lookup (0.05s)
=== RUN   TestNewMDNSService_BadParams
--- PASS: TestNewMDNSService_BadParams (0.00s)
=== RUN   TestMDNSService_BadAddr
--- PASS: TestMDNSService_BadAddr (0.00s)
=== RUN   TestMDNSService_ServiceAddr
--- PASS: TestMDNSService_ServiceAddr (0.00s)
=== RUN   TestMDNSService_InstanceAddr_ANY
--- PASS: TestMDNSService_InstanceAddr_ANY (0.00s)
=== RUN   TestMDNSService_InstanceAddr_SRV
--- PASS: TestMDNSService_InstanceAddr_SRV (0.00s)
=== RUN   TestMDNSService_InstanceAddr_A
--- PASS: TestMDNSService_InstanceAddr_A (0.00s)
=== RUN   TestMDNSService_InstanceAddr_AAAA
--- PASS: TestMDNSService_InstanceAddr_AAAA (0.00s)
=== RUN   TestMDNSService_InstanceAddr_TXT
--- PASS: TestMDNSService_InstanceAddr_TXT (0.00s)
=== RUN   TestMDNSService_HostNameQuery
--- PASS: TestMDNSService_HostNameQuery (0.00s)
=== RUN   TestMDNSService_serviceEnum_PTR
--- PASS: TestMDNSService_serviceEnum_PTR (0.00s)
PASS
ok      github.com/hashicorp/mdns       (cached)

gulducat
gulducat previously approved these changes Jun 11, 2026

@gulducat gulducat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgross tgross force-pushed the ci-update branch 2 times, most recently from 6110303 to 1c80302 Compare June 11, 2026 17:46
Update CI so that we're checking and testing against the current stable and the
previous stable. Run golangci-lint with current config and address the issues
there. Add copywrite config and ensure it runs on every PR. Tidy up the
makefile.

Ref: https://hashicorp.atlassian.net/browse/NMD-1566
@tgross tgross merged commit 52e9e65 into main Jun 11, 2026
11 checks passed
@tgross tgross deleted the ci-update branch June 11, 2026 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants