Backport of Mark expired Vault token as expired when Vault is unreachable into release/0.21.x#6613
Open
bosorawis wants to merge 3 commits into
Open
Backport of Mark expired Vault token as expired when Vault is unreachable into release/0.21.x#6613bosorawis wants to merge 3 commits into
bosorawis wants to merge 3 commits into
Conversation
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Manual backport PR to release 0.21.x
Vault credential stores have an internal job that periodically renews Vault tokens. If the renewal call returns a 403 error, the system assumes the token is no longer valid and marks it as expired.
When Vault is unreachable, the system logs an error and continues trying to renew the token past its expiration time since Vault never returns a 403 error. This change checks if the token has already expired; if so, it will mark the token as expired even when communication with Vault returns an error.
PCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.