Backport of chore: Add worker check to bats tests setup into release/0.21.x#6610
Open
hc-github-team-secure-boundary wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #6421 to be assessed for backporting due to the inclusion of the label backport/0.21.x.
The below text is copied from the body of the original PR.
Description
This PR attempts to resolve some flaky bats tests, specifically the alias tests (those are the first to run due to it being first in the list).
The flaky tests are the ones where it tries to connect to a target via an alias. When trying to reproduce the error locally, it seems like it occurs if the worker hasn't finished initializing
This PR adds a check to the script that runs these tests in CI to wait for the worker health status to be READY before proceeding. However, during testing, this wasn't sufficient. I'm not sure what else can be used to verify, so I've thrown in a manual sleep for now.
https://hashicorp.atlassian.net/browse/ICU-18167
PCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.
Overview of commits