U/avadhutp/zookeeper 327 config for quorum listen on all i ps#1
Open
avadhutp wants to merge 23 commits into
Open
U/avadhutp/zookeeper 327 config for quorum listen on all i ps#1avadhutp wants to merge 23 commits into
avadhutp wants to merge 23 commits into
Conversation
Add tick_time, sync_limit and init_limit to config
Many a time (such as logging to multiple files with ROLLING appender) it is a better to pass a custom file (templated higher up in modules calling this module) to which /etc/zookeeper/conf/zoo.cfg is symlinked. Also updated the spec tests.
Add a parameter for custom log4j properties file.
Unmanage files from dataDir and logDir
allows users to separate the location logs are stored to the snapshots. set the template so that this change has no diff where this is not set
we only want to create the directory if its specified and its specified as someting different to datadir. if they're specified as the same dir, then no need to create anything else, since zookeeper will just use the datadir
support setting datalogstore
Add config variable to toggle notifying zookeeper service
- Added unit file for zookeeper.service.
- Xenial related updates.
+ zookeeperd not required with systemd.
Also fix the restarting of zookeeper service when files are changed. There was a dependency loop which meant that if restart_zookeeper were true, the notify was being set up before service was actually defined. Bunch of minor fixes.
rspec test fixes and updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This is necessary when we do the auto-healing migration for zookeeper clusters.
When I update this module in Yelp's internal puppet, I will also set the value in
clusters/default.yamlto betrue.Testing done:
puppet-bundle exec rake specpasses