Extract the shared amount parameter into a reusable payments type#3
Merged
Conversation
|
Review Complete Risk: 🟢 Low (15/100) — no findings · 441 LOC across 9 files No issues found that meet confidence and severity thresholds. One low-severity proptest coverage note was identified but fell below the confidence threshold for inclusion. Files Reviewed (9 files) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracting logic from zcash#531. The idea is to have !531 as small as possible, and merge relatively unrelated changes to main, to decrease the reviewer time on the actual feature, while we're merging NU6.3 related changes.
Move the
AmountParameterrequest type out ofz_send_manyintojson_rpc::payments(with accessor methods) and extract the sharedbuild_requestamount-parsing helper, so the type and parsing can be reused by other send-path RPC methods. Updatez_sendmany, the method trait, and the OpenRPC generation to reference the relocated type.Mirror-of: zcash#535
zcash#535