[Blocked] Committee meeting attendees support - #842
Conversation
|
I think some more testing is needed before merging |
|
Data migration? tests? public api? unicode methods? Without tests this would contribute to technical debt. without public api, not sure what's the use.. And how are the attendants actually added? Also adding an attendee that is just a text "name" and text "role" and not a Person, is quite problematic in my view. Would be added with different names, no option to add aggregation functionality on a specific person attending. etc.. |
|
@alonisser - the goal for this is to have data available via re:dash if you prefer we can also add it in a different module under knesset-data-django, not as part of open-knesset but, in this case, due to the relationship with committee meeting it made sense to keep it here |
|
No problem with keeping it here. Although I do prefer build views or at least an api as an extension task.. redash is very specific. |
part of hasadna/knesset-data#143