Skip to content

Access logs lifecycle#110

Open
PerGon wants to merge 4 commits into
haproxy-ingress:masterfrom
PerGon:access_logs_lifecycle
Open

Access logs lifecycle#110
PerGon wants to merge 4 commits into
haproxy-ingress:masterfrom
PerGon:access_logs_lifecycle

Conversation

@PerGon

@PerGon PerGon commented May 28, 2026

Copy link
Copy Markdown
Contributor

Add controller.logs.lifecycle to the access-logs sidecar container template, matching the pattern already used by the controller and haproxy containers.

This allows configuring a preStop hook on the syslog sidecar — useful when the haproxy container also has a lifecycle rule to, for example, need a drain period before termination. Without this, the syslog container can exit before HAProxy finishes serving in-flight requests, causing those requests to go unlogged.

@jcmoraisjr jcmoraisjr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

There's already an ongoing update and tests to move log and external haproxy containers as native sidecars which makes the lifecycle configuration without a clear proposal.

It looks good anyway, since we already have distinct lifecycle configurations for controller and external haproxy, this one is easier to backport to older branches, and this could also be used for niche or very specific use cases even on native sidecar deployments.

It is missing however the update in the readme file, and since you're already updating the PR, I also pointed a nitpicking in the values update.

Comment thread haproxy-ingress/values.yaml Outdated
@PerGon

PerGon commented Jun 2, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the comments - I've addressed them :)

Cool to know about the move to native sidecar containers 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants