fix: remove unsafe exec() in vt100.c#16
Merged
haoict merged 6 commits intoMay 14, 2026
Merged
Conversation
fix ttf utf8 rendering
Automated security fix generated by Orbis Security AI
|
@orbisai0security is attempting to deploy a commit to the Hao Nguyen's projects Team on Vercel. A member of the Team first needs to authorize it. |
0bd889f to
0000450
Compare
haoict
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
src/vt100.c.Vulnerability
V-003src/vt100.c:182Description: At src/vt100.c:182, the application constructs a shell command string by embedding opt_cmd[i] directly into an sprintf format string without any sanitization or escaping. If opt_cmd[i] contains shell metacharacters such as single quotes, semicolons, backticks, or pipe characters, the resulting command string will execute arbitrary shell commands when passed to system() or popen(). An attacker who can influence opt_cmd values via command-line arguments or configuration achieves arbitrary command execution. The sprintf call is also unbounded and can overflow echo_cmd if opt_cmd[i] is sufficiently long.
Changes
src/vt100.cVerification
Automated security fix by OrbisAI Security