Godpowers 5.5.0: Arc Ready and Pillars 1.1#70
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8aa291aa5f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (current.hardeningStatus !== 'done') reasons.push(`hardening status is ${current.hardeningStatus || 'missing'}, expected done`); | ||
| if (current.explicitBlocked) reasons.push('hardening findings record a blocked launch gate'); | ||
| if (current.criticals.unresolved > 0) reasons.push(`${current.criticals.unresolved} unresolved or accepted Critical finding(s)`); |
There was a problem hiding this comment.
Require hardening timestamps before passing the gate
When state.json has tier-3.harden.status = done but the updated field is missing or not parseable, snapshot() sets hardeningUpdatedAt to null and this evaluation adds no blocker, so record() can write a passing PREPUBLICATION gate that is not bound to an authoritative hardening timestamp. Since this gate is meant to invalidate after hardening state changes, it should fail closed unless updated is a valid date.
Useful? React with 👍 / 👎.
Summary
Verification