Harden published verification and record 5.4.0 release#69
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4348b078e9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ], { env }); | ||
| const cli = path.join(installRoot, 'node_modules', 'godpowers', 'bin', 'install.js'); | ||
| assertExists(cli, `published CLI missing after isolated install: ${cli}`); | ||
| const runPublished = (args) => run(process.execPath, [cli, ...args], { env }); |
There was a problem hiding this comment.
When this verifier is run after publishing, invoking node .../bin/install.js bypasses the package manager's bin resolution. I checked npx --help, it runs a command from a local or remote npm package, so a published tarball with a missing or wrong bin.godpowers entry, or a broken .bin/godpowers shim, can still pass because bin/install.js exists. Please run the installed .bin/godpowers or npm exec --package=${spec} -- godpowers ... for at least one command before recording the release as verified.
Useful? React with 👍 / 👎.
1 participant
Summary
Verification