Fix multipart CSRF: keep body params string-keyed#519
Merged
Conversation
timriley
force-pushed
the
ensure-string-csrf-token-in-params
branch
from
0f16e7e to
9a813a4
Compare
`BodyParser` deep-symbolized its output, so multipart bodies reached params.raw under Symbol keys. `CSRFProtection` would read the token with a String key (`raw["_csrf_token"]`), so it would miss the token and reject the request. Fix this by removing the symolizing from `BodyParser`, given that `Params` is doing symbolizing anyway. This allows the `raw` to keep the string keys that `CSRFProtection` expects.
timriley
force-pushed
the
ensure-string-csrf-token-in-params
branch
from
9a813a4 to
f1bfc11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BodyParserdeep-symbolized its output, so multipart bodies would end up inparams.rawwith symbol keys. This led to issues with handling CSRF protection, becauseCSRFProtectionwould looks for the token under a String key (raw["_csrf_token"]), so would miss the token and reject the request.Fix this by removing the symolizing from
BodyParser, given thatParamsis doing symbolizing anyway. This allows therawto keep the string keys thatCSRFProtectionexpects.Fixes #518