feature(slog): support slog logger#37
Open
alekseykondratev91 wants to merge 1 commit into
Open
Conversation
alekseykondratev91
commented
Dec 18, 2023
alekseykondratev91
commented
Contributor
- add chunk zap and slog
- add struct logger in config
- add field logger in goro.yaml
- add validation supported loggers
- refactor template files
* add chunk zap and slog * add struct logger in config * add field logger in goro.yaml * add validation supported loggers * refactor template files
hanagantig
reviewed
Jan 17, 2024
| func NewLogger() (*zap.Logger, error) { | ||
| return zap.NewProduction() | ||
| func NewLogger() *slog.Logger { | ||
| handler := slog.NewJSONHandler(os.Stdout, nil) |
Owner
There was a problem hiding this comment.
it's good to add here some default fields, such as env=production, app=goro, version=0.0.1
| @@ -0,0 +1,33 @@ | |||
| package slogchunk | |||
Owner
There was a problem hiding this comment.
Let's keep only slog implementation in the generated code. Basically we will use slog everywhere and if somebody want to use different loggers - they will just implement their own handler for the slog
| @@ -0,0 +1,48 @@ | |||
| package config | |||
Owner
There was a problem hiding this comment.
no needs in all of this thing since we will keep only slog implementation in our code (check this comment )
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.