feat: code refactor

[hanachiru]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on internal code refactoring and quality improvements within the RapidEnum project. The changes streamline the enum source generation logic, enhance nullability handling for better type safety, and standardize code formatting across the codebase. These adjustments contribute to a more robust, readable, and maintainable project without introducing new features or altering external behavior.

Highlights

• Refactored Code Generation Logic: The RapidEnumGenerator was refactored to directly utilize RapidEnumTemplate.Generate for source output, eliminating a redundant RenderEnumUtils method and streamlining the code generation process.
• Improved Nullability Handling: The RapidEnumGeneratorContext record now explicitly handles nullability for EnumFullName, EnumNames, and EnumMemberValues properties, enhancing type safety and robustness. Corresponding Equals and GetHashCode methods were updated to correctly account for these nullable types.
• Enhanced Template Robustness: The RapidEnumTemplate was updated to gracefully handle potentially null EnumNames and EnumMemberValues during string interpolation, preventing potential runtime errors in edge cases.
• Consistent Code Formatting: Whitespace and formatting were standardized across various project files, including .csproj files, benchmark code, sample enums, and test files, improving readability and maintainability.
• Markdown Table Formatting Fix: A minor formatting issue in the AnalyzerReleases.Shipped.md file was corrected to ensure proper rendering of the Markdown table.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• RapidEnum.Benchmark/Program.cs
  • Removed trailing whitespace in benchmark methods.
• RapidEnum.Benchmark/RapidEnum.Benchmark.csproj
  • Removed trailing whitespace from ProjectReference and PackageReference elements.
• RapidEnum.Generators/AnalyzerReleases.Shipped.md
  • Corrected Markdown table formatting by adding missing pipe characters.
• RapidEnum.Generators/RapidEnum.Generators.csproj
  • Removed trailing whitespace from MSBuild tasks and item groups.
• RapidEnum.Generators/RapidEnumGenerator.cs
  • Removed trailing whitespace from conditional statements.
  • Replaced direct call to RenderEnumUtils with RapidEnumTemplate.Generate.
  • Removed the private RenderEnumUtils method.
• RapidEnum.Generators/RapidEnumGeneratorContext.cs
  • Changed EnumFullName, EnumNames, and EnumMemberValues properties to be nullable.
  • Initialized nullable properties to null in the diagnostic constructor.
  • Updated Equals method to handle null checks for nullable properties.
  • Updated GetHashCode method to handle null checks for nullable properties.
  • Removed trailing whitespace.
• RapidEnum.Generators/RapidEnumTemplate.cs
  • Added using System; directive.
  • Updated string interpolation syntax from $$$ to $$.
  • Added null-coalescing operators (?? []) to EnumNames and EnumMemberValues in template generation to prevent null reference exceptions.
  • Removed trailing whitespace.
• RapidEnum.NuGet/RapidEnum.NuGet.csproj
  • Adjusted indentation for PropertyGroup and ItemGroup elements.
• RapidEnum.NuGet/RapidEnum.nuspec
  • Removed trailing whitespace from the repository URL element.
• RapidEnum.Sample/RapidEnum.Sample.csproj
  • Removed trailing whitespace from ProjectReference and PackageReference elements.
• RapidEnum.Sample/SampleEnum.cs
  • Reformatted enum members to be on a single line with their attributes.
  • Removed trailing whitespace.
• RapidEnum.Tests/RapidEnum.Tests.csproj
  • Removed trailing whitespace from PackageReference and ProjectReference elements.
• RapidEnum.Tests/RapidEnumTest.cs
  • Reformatted enum members to be on a single line with their attributes.
  • Removed trailing whitespace.
• RapidEnum.Tests/RapidEnumTestWithFastEnum.cs
  • Reformatted enum members to be on a single line with their attributes.
  • Adjusted formatting for IsDefinedUsingNamePassTest and ParsePassTest assertions.
  • Removed trailing whitespace.
• RapidEnum.Tests/RapidEnumTestWithSystem.cs
  • Reformatted DateTimeKindEnumExtensions class declaration.
  • Removed trailing whitespace.
• RapidEnum.Tests/RapidEnumTestWithThirdParty.cs
  • Reformatted JsonTokenTypeEnumExtensions class declaration.
  • Removed trailing whitespace.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request primarily consists of code refactoring and style improvements. The changes include making several properties in RapidEnumGeneratorContext nullable and correctly updating consumers of this class, which also fixed a bug in the GetHashCode implementation. The code base has been cleaned up by removing trailing whitespace, improving formatting, and inlining a redundant helper method. Overall, these changes improve code quality and maintainability. My only concern is the removal of the final newline character from multiple files, which I've commented on.

[gemini-code-assist]

This file, and several others in this pull request, is missing a final newline character. It is a widely-accepted convention to end files with a newline. This prevents issues with various command-line tools and source control systems. For example, git diff may show a "No newline at end of file" warning. Please consider adding a final newline to all modified files where it has been removed.