-
Notifications
You must be signed in to change notification settings - Fork 2
test #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hamid97m
wants to merge
14
commits into
test
Choose a base branch
from
master
base: test
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
test #11
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
d4b3c29
Use relative path for README images
alibagherifam 3c96e74
Merge branch 'feature-improve-sample-app' into feature-update-readme
alibagherifam b31b90f
Fix after merge conflict
alibagherifam cb6ab35
Mention sample app in the README
alibagherifam e4faead
Remove typo
alibagherifam 6b64e48
Add license
alibagherifam 1899a10
Merge remote-tracking branch 'origin/master' into feature-update-readme
alibagherifam 0dbe1fb
Fix license
alibagherifam 03931f1
Merge pull request #9 from alibagherifam/feature-update-readme
hamid97m c4f25e8
Update README.md
hamid97m fbd2796
Update README.md
hamid97m 32c58bd
Added the option to set the initial selected date
willliam99 387e1c5
Merge pull request #10 from WilliamGates99/master
hamid97m 752337d
ci: update .deepsource.toml
deepsource-io[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| version = 1 | ||
|
|
||
| [[analyzers]] | ||
| name = "java" | ||
|
|
||
| [analyzers.meta] | ||
| runtime_version = "11" | ||
|
|
||
| [[analyzers]] | ||
| name = "kotlin" | ||
|
|
||
| [analyzers.meta] | ||
| runtime_version = "1.8" | ||
| language_version = "1.7" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,12 +20,14 @@ import com.hamid97m.herodatepicker.utils.ShamsiHeroDatePicker | |
| import java.util.Date | ||
|
|
||
| /** | ||
| * @param selectedDate sets the initial selected gregorian date. | ||
| * @param selectableYearRange determines the range of years that is selectable. | ||
| * @param isSelectFromFutureEnable if false, the max date that would be selected is now. | ||
| */ | ||
| @Composable | ||
| fun HeroDatePicker( | ||
| modifier: Modifier = Modifier, | ||
| selectedDate: Date = Date(System.currentTimeMillis()), | ||
| selectableYearRange: Iterable<Int>? = null, | ||
| isSelectFromFutureEnable: Boolean = false, | ||
| textStyle: TextStyle = LocalTextStyle.current, | ||
|
|
@@ -51,18 +53,23 @@ fun HeroDatePicker( | |
| ) | ||
| } | ||
| } | ||
|
|
||
| val selectedDateShamsi = ShamsiDatePickerUtill() | ||
| selectedDateShamsi.gregorianToPersian(selectedDate) | ||
|
|
||
| LaunchedEffect(Unit) { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. issue: LaunchedEffect should depend on selectedDate to handle parameter updates properly. Currently, changes to selectedDate won't trigger an update of the initial selection. Change Unit to selectedDate to ensure the effect runs when the parameter changes. |
||
| onSelectedDateChange( | ||
| SelectedDate( | ||
| currentDateShamsi.year, | ||
| currentDateShamsi.month, | ||
| currentDateShamsi.day | ||
| selectedDateShamsi.year, | ||
| selectedDateShamsi.month, | ||
| selectedDateShamsi.day | ||
| ) | ||
| ) | ||
| } | ||
| var selectedYear by remember { mutableStateOf(currentDateShamsi.year) } | ||
| var selectedMonth by remember { mutableStateOf(currentDateShamsi.month) } | ||
| var selectedDay by remember { mutableStateOf(currentDateShamsi.day) } | ||
|
|
||
| var selectedYear by remember { mutableStateOf(selectedDateShamsi.year) } | ||
| var selectedMonth by remember { mutableStateOf(selectedDateShamsi.month) } | ||
| var selectedDay by remember { mutableStateOf(selectedDateShamsi.day) } | ||
|
|
||
|
|
||
|
|
||
|
|
@@ -104,10 +111,6 @@ fun HeroDatePicker( | |
| onSelectedDateChange(SelectedDate(selectedYear, selectedMonth, selectedDay)) | ||
| } | ||
| ) | ||
|
|
||
| } | ||
|
|
||
| } | ||
|
|
||
|
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| MIT License | ||
|
|
||
| Copyright (c) 2023 Hamid Mahmoodi | ||
|
|
||
| Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| of this software and associated documentation files (the "Software"), to deal | ||
| in the Software without restriction, including without limitation the rights | ||
| to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| copies of the Software, and to permit persons to whom the Software is | ||
| furnished to do so, subject to the following conditions: | ||
|
|
||
| The above copyright notice and this permission notice shall be included in all | ||
| copies or substantial portions of the Software. | ||
|
|
||
| THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| SOFTWARE. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: Add validation for selectedDate against isSelectFromFutureEnable constraint.
If isSelectFromFutureEnable is false but selectedDate is in the future, this creates an inconsistent state. Consider adding validation at the start of the composable.