feat: property-editor by henry9610 · Pull Request #533 · haiwen/seafile-iOS

henry9610 · 2026-06-12T14:30:12Z

Add file property editor

lilthree · 2026-06-15T02:56:36Z

+#import "../Chips/SeafCollaboratorChipView.h"
+#import "../Chips/SeafTagChipView.h"
+#import "../Selectors/SeafTagSelectorViewController.h"
+#import "../Services/SeafSdocService.h"


直接文件名导入就行，不需要用相对路径，工程配置文件里面有文件搜索路径的配置

好的，已修改

lilthree · 2026-06-15T02:59:54Z

+        }];
+    }
+    return [UIColor colorWithRed:0x66/255.0 green:0x66/255.0 blue:0x66/255.0 alpha:1.0];
+}


这些uikit相关的能力，不推荐用C 静态函数，可以直接写个专门的子类或者UIView的分类。

这几个样式函数仅在本文件内使用，scope 有限，暂保持现状，后续迭代再考虑抽分类。

lilthree · 2026-06-15T03:02:32Z

+        [self.scrollView.topAnchor constraintEqualToAnchor:self.view.safeAreaLayoutGuide.topAnchor],
+        [self.scrollView.leadingAnchor constraintEqualToAnchor:self.view.safeAreaLayoutGuide.leadingAnchor],
+        [self.scrollView.trailingAnchor constraintEqualToAnchor:self.view.safeAreaLayoutGuide.trailingAnchor],
+        [self.scrollView.bottomAnchor constraintEqualToAnchor:self.view.bottomAnchor],


这里底部对其safeArea bottom是不是更合理

这里不用修改，scrollView bottom 用物理边是为了底部的safeArea的穿透显示效果，避免内容过长时，底部安全区域显示纯色遮挡

后面keyboardWillChangeFrame里面中用 CGRectGetMaxY(self.view.bounds) 把bottomSafeArea的高度算计去了，这里可以确认下距离键盘的高度是不是偏高了。

已确认，这里的计算是正确的，真机测试了一下看起来也没有问题。
scrollView 是延伸到屏幕最底部的，与 CGRectGetMaxY(self.view.bounds) 的基准一致

lilthree · 2026-06-15T03:03:46Z

+        [self.stackView.leadingAnchor constraintGreaterThanOrEqualToAnchor:self.scrollView.contentLayoutGuide.leadingAnchor],
+        [self.scrollView.contentLayoutGuide.widthAnchor constraintEqualToAnchor:self.scrollView.frameLayoutGuide.widthAnchor],
+        [self.stackView.widthAnchor constraintLessThanOrEqualToConstant:700],
+        fullWidth,


这个布局在iPad上可能会有冲突

这里我在iPad 上实测了一下没有约束冲突。fullWidth 用了 priority 750，会被 maxWidth ≤ 700自动打破，表单居中显示，左右两侧有留白。

lilthree · 2026-06-15T03:08:57Z

+    // Dismiss the profile sheet first, then present editor
+    __weak typeof(self) weakSelf = self;
+    [self dismissViewControllerAnimated:YES completion:^{
+        if (!weakSelf.connection || !weakSelf.aggregate || !weakSelf.repoId) return;


这种dismiss回调可能存在销毁的情况，最好是加上strongself
__strong typeof(weakSelf) strongSelf = weakSelf;
if (!strongSelf.connection || !strongSelf.aggregate || !strongSelf.repoId) return;

对的，这里加上更安全，已修复

lilthree · 2026-06-15T04:17:19Z

+
+    if (editable) {
+        [textField addTarget:self action:@selector(textFieldDidChange:) forControlEvents:UIControlEventEditingChanged];
+        objc_setAssociatedObject(textField, "metadataKey", key, OBJC_ASSOCIATION_COPY_NONATOMIC);


objc_setAssociatedObject的key判断的是指针不是字符串，应该是用static const void *kMetadataKey = &kMetadataKey。这个vc里面掺杂了对UIView、UITextField、UILabel等的关联属性动态绑定的方法，代码结构上不太优雅，建议封装一个UIView的分类，把这些属性添加到分类中。另外也可把buildTextFieldForKey和buildNumberFieldForKey修改成UITextField的子类SeafProfileTextField和SeafNumberTextField。

好的，key 会改成 static const void * 的标准写法。子类抽取改动较大，可以先等版本和功能页面稳定后，后续迭代再优化。

lilthree · 2026-06-15T04:18:42Z

这个vc的代码过于庞大了，可以考虑把数据解析与转换和UI 构建的逻辑单独抽离出来。

这个VC支持的字段较多，做大范围改动需要再完整的检查和测试。当前版本先保持，待功能稳定后，后续迭代中可以考虑用 Category 或完整的重构做进一步的文件级拆分

lilthree · 2026-06-15T04:21:47Z

+//  Uses UITableView with chip-style tag cells and selection checkmarks.
+
+#import "SeafTagSelectorViewController.h"
+#import "../Chips/SeafTagChipView.h"


这里导入也不需要路径

lilthree · 2026-06-15T04:22:34Z

 #import "SeafSdocProfileSheetViewController.h"
+#import "Editor/SeafSdocProfileEditorViewController.h"
+#import "Chips/SeafTagChipView.h"
+#import "Services/SeafSdocService.h"


import "SeafSdocProfileEditorViewController.h"、import "SeafTagChipView.h"、import "SeafSdocService.h"

lilthree · 2026-06-15T04:23:01Z

@@ -1,5 +1,6 @@
 #import "SeafPhotoInfoView.h"
 #import "Debug.h"
+#import "SDoc/Chips/SeafCollaboratorChipView.h"


#import "SeafCollaboratorChipView.h"

henry9610 added 2 commits June 12, 2026 22:24

feat: add Wiki tab with list page and WebView

118d30c

feat: property-editor

03afbc6

henry9610 force-pushed the feature/property-editor branch from 835a24e to 03afbc6 Compare June 12, 2026 14:35

henry9610 requested a review from lilthree June 12, 2026 14:44

lilthree reviewed Jun 15, 2026

View reviewed changes

pr issue fix

193f937

henry9610 force-pushed the dev branch from 118d30c to f717c1f Compare June 18, 2026 02:22

Conversation

henry9610 commented Jun 12, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

henry9610 Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

henry9610 Jun 15, 2026 •

edited

Loading