add LIBSEARPC_ASYNC_API_WORKS define#81
Open
stsp wants to merge 1 commit into
Open
Conversation
Commit ed7b992 fixed async API, but now the application needs a check that the API is usable. Add LIBSEARPC_ASYNC_API_WORKS define.
Contributor
Author
|
Guys, its absolutely problematic |
stsp
added a commit
to dosemu2/dosemu2
that referenced
this pull request
Jul 23, 2026
Due to haiwen/libsearpc#81 While configure check was added in the prev commit, it doesn't work when cross-compiling.
stsp
added a commit
to dosemu2/dosemu2
that referenced
this pull request
Jul 23, 2026
Due to haiwen/libsearpc#81 While configure check was added in the prev commit, it doesn't work when cross-compiling.
stsp
added a commit
to dosemu2/dosemu2
that referenced
this pull request
Jul 23, 2026
libsearpc upstream applied haiwen/libsearpc#79 but not haiwen/libsearpc#81 which made it impossible to detect if the lib is fixed or not. The fix itself was backward-incompatible with any work-around, so using the lib is no longer possible at all because you never know if it needs a work-around or not. The simplest fix is to fork the broken searpc-client.c and add a fixed version of it into the build.
stsp
added a commit
to dosemu2/dosemu2
that referenced
this pull request
Jul 23, 2026
libsearpc upstream applied haiwen/libsearpc#79 but not haiwen/libsearpc#81 which made it impossible to detect if the lib is fixed or not. The fix itself was backward-incompatible with any work-around, so using the lib is no longer possible at all because you never know if it needs a work-around or not. The simplest fix is to fork the broken searpc-client.c and add a fixed version of it into the build.
stsp
added a commit
to dosemu2/dosemu2
that referenced
this pull request
Jul 23, 2026
libsearpc upstream applied haiwen/libsearpc#79 but not haiwen/libsearpc#81 which made it impossible to detect if the lib is fixed or not. The fix itself was backward-incompatible with any work-around, so using the lib is no longer possible at all because you never know if it needs a work-around or not. The simplest fix is to fork the broken searpc-client.c and add a fixed version of it into the build.
stsp
added a commit
to dosemu2/dosemu2
that referenced
this pull request
Jul 23, 2026
libsearpc upstream applied haiwen/libsearpc#79 but not haiwen/libsearpc#81 which made it impossible to detect if the lib is fixed or not. The fix itself was backward-incompatible with any work-around, so using the lib is no longer possible at all because you never know if it needs a work-around or not. The simplest fix is to fork the broken searpc-client.c and add a fixed version of it into the build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit ed7b992 fixed async API, but now the application needs a check that the API is usable.
Add LIBSEARPC_ASYNC_API_WORKS define.