Check the buffer ticker channel in the main loop to avoid dropping data in Publish()#3
Open
stanhu wants to merge 1 commit into
Open
Check the buffer ticker channel in the main loop to avoid dropping data in Publish()#3stanhu wants to merge 1 commit into
stanhu wants to merge 1 commit into
Conversation
stanhu
force-pushed
the
fix-dropped-events
branch
from
January 19, 2016 01:46
0cf8bdb to
6e51e00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working with the logslam code, I noticed a number of my events were not being published on occasion. It turns out if the ticker event is fired,
selectwill fire one of the two events. It's possible the event gets dropped as a result.