73: fix 'platform vesync does not generate unique IDs' log spam#74
Open
XerxesDGreat wants to merge 1 commit into
Open
73: fix 'platform vesync does not generate unique IDs' log spam#74XerxesDGreat wants to merge 1 commit into
XerxesDGreat wants to merge 1 commit into
Conversation
When building up the list of entities to register, the integration currenty appends to device lists on each update call. This causes duplicate entities, including the ids which end up causing the above error. This patch performs deduplication, building up a unique list of entities and eliminating the log spam.
Rainbow45-pixel
suggested changes
May 9, 2026
Rainbow45-pixel
left a comment
Rainbow45-pixel
left a comment
There was a problem hiding this comment.
Does not work.
No changes, new device on every reboot
Author
|
which device/devices do you have? It has worked consistently for me for the last 6 weeks. Also are you the maintainer of this repo? |
|
I'm not the maintainer, only a annoyed user. |
Rainbow45-pixel
approved these changes
May 22, 2026
There was a problem hiding this comment.
Damn, it's not working after all. at second restart of HA ich have a new Vesync device detection...
i have applied the changes from #72 too, now the problem ist fixed. i haven't read before
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue #73
When building up the list of entities to register, the integration currenty appends to device lists on each update call. This causes duplicate entities, including the ids which end up causing the above error. This patch performs deduplication, building up a unique list of entities and eliminating the log spam.