Skip tsparticles deps that break yarn resolve#943
Open
ludeeus wants to merge 1 commit into
Open
Conversation
The npm packument for tsparticles-preset-links was modified on 2026-03-17, leaving a null field that crashes yarn 4.5.3's resolver with "Cannot convert undefined or null to object". The pinned homeassistant-frontend submodule still lists tsparticles-engine and tsparticles-preset-links in its dependencies, so script/bootstrap has been failing for every PR since. Neither package is imported anywhere in this repo. Add a dependenciesIgnore array (mirroring the existing *Override pattern) that merge_requirements.js uses to strip listed keys from the merged dependencies before writing package.json, and regenerate yarn.lock.
There was a problem hiding this comment.
Pull request overview
The pinned homeassistant-frontend submodule lists tsparticles-engine and tsparticles-preset-links as dependencies, but neither is used in this repo and they break yarn install during script/bootstrap. This PR introduces a dependenciesIgnore array in the root package.json and updates script/merge_requirements.js to filter those keys out of the merged dependency map before writing the regenerated package.json, then regenerates yarn.lock accordingly.
Changes:
- Add
omitKeyshelper and adependenciesIgnorestep inscript/merge_requirements.jsmirroring the existing*Overridepattern. - Declare
dependenciesIgnore: ["tsparticles-engine", "tsparticles-preset-links"]inpackage.jsonand remove the previous direct entries. - Regenerate
yarn.lockto drop alltsparticles-*entries.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| script/merge_requirements.js | Adds omitKeys helper and applies hacs.dependenciesIgnore after merging core and override dependencies. |
| package.json | Removes the tsparticles-* direct deps and declares the new dependenciesIgnore array next to the existing override fields. |
| yarn.lock | Removes the workspace entries and transitive lock entries for the tsparticles-* packages. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pinned homeassistant-frontend submodule still lists tsparticles-engine and tsparticles-preset-links in its dependencies, so script/bootstrap has been failing for every PR since.
Neither package is imported anywhere in this repo. Add a dependenciesIgnore array (mirroring the existing *Override pattern) that merge_requirements.js uses to strip listed keys from the merged dependencies before writing package.json, and regenerate yarn.lock.