fix: better api annotation of valcons matching selection's type#1071
Merged
Conversation
Contributor
Author
|
This implements #1067 (comment) |
Signed-off-by: Ben Price <ben@hackworthltd.com>
brprice
force-pushed
the
brprice/valcon-matches-type
branch
from
a771fe1 to
edd18ce
Compare
Member
|
Thanks! However, keep in mind that what's currently deployed is not |
Member
|
I will rebase #1070 when this PR is merged to main, so that we can get this deployed. Thanks all! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.