Skip to content

Add configuration for check button#7

Open
yukhnevych wants to merge 1 commit into
h5p:masterfrom
yukhnevych:add-configuration-for-check-button
Open

Add configuration for check button#7
yukhnevych wants to merge 1 commit into
h5p:masterfrom
yukhnevych:add-configuration-for-check-button

Conversation

@yukhnevych

@yukhnevych yukhnevych commented Jun 2, 2017

Copy link
Copy Markdown

@icc this is the part of H5P.QuestionSet pull request.

@icc

icc commented Jun 23, 2017

Copy link
Copy Markdown
Member

Thanks for the pull request. I've created an issue for getting it merged in: HFP-1217

The following needs to be fixed before this can be merged in:

  1. Adding new fields to the top of an array in semantics.json require that all the translation files in language/ are updated, if not the labeling in the editor will be incorrect for those using the translations.
  2. The new field should us a conditional widget to hide the checkboxes used to disable the other buttons. This makes for a cleaner UI as changing the new checkbox always makes the other buttons hidden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants