Harmonize getAnswerGiven with other content types#32
Open
otacke wants to merge 2 commits into
Open
Conversation
The function getAnswerGiven should report true if an answer has been given. Other content types return true if either an answer has been given explicitly or nothing has been answered explicity, but "check" has been clicked. True-False did not do the latter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function getAnswerGiven should report true if an answer has been given.
Other content types return true if either an answer has been given explicitly
or nothing has been answered explicity, but "check" has been clicked.
True-False did not do the latter. In Course Presentation, this led to inconsistent behavior in the navigation bar. Other content types would report true when clicking on the check button even without giving an answer and the dot on the slide's navigation bar would be filled. It would not be filled for TrueFalse however if no answer was chosen before clicking on the check button.