HFP-3654 Fix trailing "dot" for screen readers#16
Open
otacke wants to merge 1 commit into
Open
Conversation
otacke
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged in, will prevent the score feedback to create a string that may cause the
readfunction to read something likeYou got x out of y points. . Something else(with an extra "dot" in between).background
Currently, when building the string that's read as feedback from the score bar and the
contentstring is empty, the resulting string will be something like:You got x out of y points.with a trailing space at the end. When the read function receives some other string before the feedback is read, it will concatenate the feedback string with the other string, but also put a.in between that will cause a "dot" to be read.