Fix current question text not passed to navigation component#189
Open
otacke wants to merge 2 commits into
Open
Fix current question text not passed to navigation component#189otacke wants to merge 2 commits into
otacke wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix 1: The aria label text to be assigned to the navigation bar's progress dot (
currentQuestionText) is now passed to the navigation component.Bug fix 2: The comparison for the progress type now uses the correct comparator
===following the coding style guidelines.What is the current behaviour?
When the progress dot of H5P.Components.ProgressDots tries to set the
currentQuestionTexton its ARIA label, it printsundefined, because it never received that text from H5P.Components.Navigation, because that in turn never received it from H5P.QuestionSet.What is the new behaviour?
The aria label text to be assigned to the navigation bar's progress dot (
currentQuestionText) is now passed to the navigation component and thus to the progress dot.PR Checklist
Before submitting, please confirm:
Read the contribution guidelines to get your pr accepted more quickly.