feature/accurate-scoring-onload-fix#109
Open
rider-griffin wants to merge 3 commits into
Open
Conversation
… needing to see them
…roles chance to instantiate
…oad-fix feature/accurate-scoring-onload-fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
registerDomElements() is called upon instantiation to accurately calculate score of the the question. This is necessary for parent libraries, such as Interactive Video, because score calculation requires the question to exist in the DOM.
Before this change, this would cause users to lose score data upon leaving and coming back to a content such as interactive video, essentially forcing them to revisit every question they've answered in order to receive an accurate score. This change also fixes the issue of the endscreen of Interactive Video reflecting 0's on all scores related to multiple choice questions.
More details on this issue are cited here:
https://h5p.org/node/547910
h5p/h5p-interactive-video#154