Skip to content

HFP-1884 don't impose align:center#82

Open
lucaboesch wants to merge 1 commit into
h5p:masterfrom
lucaboesch:master
Open

HFP-1884 don't impose align:center#82
lucaboesch wants to merge 1 commit into
h5p:masterfrom
lucaboesch:master

Conversation

@lucaboesch

Copy link
Copy Markdown

@otacke

otacke commented Jun 29, 2021

Copy link
Copy Markdown
Contributor

@lucaboesch Just removing the CSS value would very likely change the behavior of existing content after updating.

If people got used to the bug (as I did), they would not click on the center button anymore but rely on content being centered either way. If you now just take away that styling, the text would be left aligned.

I think In addition you should also have to take care of existing contents first by updating them via H5P's upgrade mechanism. You could center them for real in HTML. This way, people could change the alignment to left or right themselves if they want to by editing the content after the upgrade - but their existing content will not break forcing them to manually change everything back to centered.

I have done the same for Dialogcards in case you want to see a reference: https://github.com/h5p/h5p-dialogcards/pull/96/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants