Use user defined hover text for images in tasks#45
Open
otacke wants to merge 2 commits into
Open
Conversation
With changing the image hover handling when metadata were introduced, images within draggables used the images metadata title for the hover text, but not what the user specified in the editor of Drag-and-Drop. This change overrides the image hover text for draggable images. The hover for both, the draggable container and the image itself will now be the same.
With changing the image hover handling when metadata were introduced, static images used the images metadata title for the hover text, but not what the user specified in the editor of Drag-and-Drop. This change overrides the image hover text for static images. It will be what's specified by the user, so possibly empty and not displayed at all.
Contributor
|
Works OK when end-user views the drag & drop content. Does not seem to work in Edit mode. |
Contributor
Author
|
How could it? This is not the editor. |
Contributor
|
You're right, @otacke this is not an issue with h5p-drag-question itself, but with its editor. I've posted an issue to h5p-editor-drag-question. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With changing the image hover handling when metadata were introduced, static images and draggable used the image's metadata title for the hover text, but not what the user specified in the editor of Drag-and-Drop.
This change overrides the image hover text for static images and draggable. It will be what's specified by the user, so possibly empty and not displayed at all. For draggables, the hover for both, the draggable container and the image itself will now be the same.