HFP-2444 Prevent max score not being achievable#116
Open
otacke wants to merge 1 commit into
Open
Conversation
|
Hi, Here the result: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, there are a couple of scenarios that will lead to a maximum score being computed that is higher than the score that can be achieved. In particular, it's possible that a dropzone is set to only accept one element but two elements require to be put onto that dropzone without any alternative. In that case, Drag and Drop currently will issue two points possible while one can only get one.
While there may be cases for Kobayashi-Maru tests, it probably makes more sense to never set the maximum score higher than the achievable score.
When merged in, the
calculateMaxScorefunction will fix this problem. Papi Jo has already verified this claim for a couple of different scenarios, please cmp. https://h5p.org/node/1187680.