condensed sponsor code - #240
Open
hannahlee8 wants to merge 1 commit into
Open
Conversation
nehagb99
requested changes
Apr 7, 2023
nehagb99
left a comment
nehagb99
left a comment
Collaborator
There was a problem hiding this comment.
looks like if you click on the 'details' button under the failing check, this is what it says:
Detect any explicit "any" type, it should be replaced by another specific valid type (e.g string, number, boolean)
i think you're using the 'any' type for passing in props and for defining sponsor in your map function on line 14. if you could just change the type to match what it should be (i think the career fair Header has an example of doing that for the props being passed in), the check should probably pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Condensed sponsors code in 2023 career fair site and 2022 hackathon site
