Refactor SQLrunner, add documentation, bug fixes to joins and node persistence#1
Merged
Conversation
Collapse duplicate count(*) join projections so scalar join counts expose one result column. Make outer join detection deterministic when aliases are iterated from a map. Classify persisted bitmap files by on-disk path shape so row-id bitmap files under BSI fields reload as standard bitmaps. Skip direct Pogreb read test while a local cluster is running and fail cleanly on Pogreb open/close errors.
Migrate primary SQLRunner scripts to YAML suites with full result validation and supported, xfail, and skip outcomes. Run SQL conformance integration tests through the roadmap runner while retaining legacy scripts for specialized topology tests. Add local cluster, Consul, log, and integration-test scripts. Document development, deployment, SQL roadmap, and legacy compatibility guidance.
Migrate primary SQLRunner scripts to YAML suites with full result validation and supported, xfail, and skip outcomes. Run SQL conformance integration tests through the roadmap runner while retaining legacy scripts for specialized topology tests. Add local cluster, Consul, log, and integration-test scripts. Document development, deployment, SQL roadmap, and legacy compatibility guidance.
…identify anything out of sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix join count projection and deterministic outer join behavior.
Correct persisted bitmap classification during cluster restart.
Harden direct Pogreb retention testing.
Add YAML SQL roadmap suites with full result-set validation.
Migrate primary SQLRunner basic, insert, mutation, and join tests.
Preserve unsupported SQL behavior as explicit xfail roadmap goals.
Retain legacy SQL scripts for specialized topology and retention tests.
Add local Consul, cluster, logging, and integration-test scripts.
Add architecture, deployment, development, quick-start, and status documentation.
Simplify CI by removing unused LocalStack setup and repairing repository checkout.
Validation
Build and unit tests pass.
Basic, insert, mutation, and join integration suites pass.
Cluster restart and persisted-data verification pass.
GitHub Actions is green on develop.
Remaining Work
Legacy SQLRunner fragments remain compatibility debt for topology, Docker, restart, and retention tests.
SQL roadmap xfail cases document known unsupported or incorrect behavior.
Broader SQL and join-engine refactoring is intentionally deferred.