Ensure no connections older than max lifetime are returned#54
Merged
Conversation
Currently when a connection is returned it is checked to ensure it is younger than the maximum configured connection lifetime. However only the first connection retrieved from the pool is checked, the fallback is not. So check the age of the fallback to ensure no connections are given out that exceed the maximum confirued connection lifetime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when a connection is returned it is checked to ensure it is younger than the maximum configured connection lifetime. However only the first connection retrieved from the pool is checked, the fall-back is not. So check the age of the fall-back to ensure no connections are given out that exceed the maximum configured connection lifetime.