Skip to content

Ignore mima for deleted private class #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guymers merged 2 commits into from
Jul 11, 2026
Merged

Ignore mima for deleted private class #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab9535e
Ignore mima for deleted private class
guymers Jul 11, 2026
33c0ac5
sdsd
guymers Jul 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,13 @@ jobs:
uses: actions/setup-java@1bcf9fb12cf4aa7d266a90ae39939e61372fe520 # v5.4.0
with:
distribution: zulu
java-version: '21'
java-version: 21
java-package: jdk
cache: sbt

- name: Install SBT
uses: sbt/setup-sbt@66fb4376e81982c7d92a4074170846fff88e2e30 # v1.5.0

- name: Cache SBT
uses: coursier/cache-action@95e5b1029b6b86e7bac033ee44a0697d8a527d2d # v8.1.1

- name: Lint
run: sbt --client "++${{ matrix.scala }} scalafmtCheckAll"

Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,13 @@ jobs:
uses: actions/setup-java@1bcf9fb12cf4aa7d266a90ae39939e61372fe520 # v5.4.0
with:
distribution: zulu
java-version: '21'
java-version: 21
java-package: jdk
cache: sbt

- name: Install SBT
uses: sbt/setup-sbt@66fb4376e81982c7d92a4074170846fff88e2e30 # v1.5.0

- name: Cache SBT
uses: coursier/cache-action@95e5b1029b6b86e7bac033ee44a0697d8a527d2d # v8.1.1

- name: Release
run: sbt ci-release
env:
Expand Down
15 changes: 11 additions & 4 deletions build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
// format: off

import com.typesafe.tools.mima.core.MissingClassProblem
import com.typesafe.tools.mima.core.ProblemFilters
import sbt.util.CacheImplicits.given
import xsbti.HashedVirtualFileRef

// format: off

val catsVersion = "2.13.0"
val fs2Version = "3.13.0"
val zioVersion = "2.1.19"
Expand Down Expand Up @@ -134,6 +136,11 @@ lazy val core = module("core")
)
case _ => Seq.empty
}),
mimaBinaryIssueFilters ++= Seq(
// was private
ProblemFilters.exclude[MissingClassProblem]("ceesvee.CsvParser$Slice"),
ProblemFilters.exclude[MissingClassProblem]("ceesvee.CsvParser$Slice$"),
),
)

lazy val fs2 = module("fs2")
Expand Down Expand Up @@ -182,11 +189,11 @@ ThisBuild / testDataResources := Def.cachedTask {
val s = streams.value

val dir = (ThisBuild / testDataResourceDirectory).value
val files = TestFiles.Csv.toSeq.map { case (f, (url, hash)) =>
val files = TestFiles.Csv.toSeq.map { case (f, (url, hash)) =>
val file = dir / "csv" / f
TestFiles.download(s.log, file, url, hash)
file
} ++ TestFiles.Tsv.map { case (f, (url, hash)) =>
} ++ TestFiles.Tsv.map { case (f, (url, hash)) =>
val file = dir / "tsv" / f
TestFiles.download(s.log, file, url, hash)
file
Expand Down