Fixing issues in text size when DPI scale is different on an Android device#34
Open
badduck32 wants to merge 5 commits into
Open
Fixing issues in text size when DPI scale is different on an Android device#34badduck32 wants to merge 5 commits into
badduck32 wants to merge 5 commits into
Conversation
This function behaves strangely on Android (due to differences in DPI I think)
gustavostuff
approved these changes
Mar 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the textsized changed a lot when comparing my phone to my laptop, both running the same code. I made a fix that changes each occurence of love.window.toPixels(n) to just n, which fixed it on my device. I think this is because of some API changes in love 11.0.
I haven't thoroughly tested it but it works fine on my device last time I checked.