feat(api): scaffold packages/api with health group contract (Step 1a)#142
Open
guidefari wants to merge 1 commit into
Open
feat(api): scaffold packages/api with health group contract (Step 1a)#142guidefari wants to merge 1 commit into
guidefari wants to merge 1 commit into
Conversation
Step 1a of the Hono -> Effect HttpApi migration (docs/migration-effect-http-api.md). - New leaf workspace package packages/api (depends only on effect), so server-only code cannot leak into the www client bundle. - Health group contract: live (/health/live), ready (/health/ready), and check (/health) endpoints with response schemas mirroring the current Hono behavior. - ReadinessCheckFailedError (Schema.TaggedErrorClass, httpApiStatus 500) for the readiness failure path. No apps/vps changes -- nothing serves this contract yet. Unit tests for the contract land in 1b. Also revises the migration doc's step breakdown into smaller single-purpose check-ins after closing #136.
This was referenced Jul 10, 2026
This was referenced Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 1a of the Hono -> Effect HttpApi migration (
docs/migration-effect-http-api.md), redone after closing #136 for scope creep. This PR is contract-only, on purpose.What
packages/api(depends only oneffect@4.0.0-beta.93) so server-only code cannot leak into thewwwclient bundle.live(/health/live),ready(/health/ready),check(/health) endpoints with response schemas mirroring current Hono behavior.ReadinessCheckFailedError(Schema.TaggedErrorClass,httpApiStatus: 500) for the readiness failure path.What this deliberately does NOT do
apps/vpschanges. Nothing serves this contract yet.Verification
bun --filter='@gbfm/api' typecheck-- cleanbun run lint/bun run format:check-- cleanNext
1b: contract unit tests (schema decode/encode, error tagging) in
packages/api.