fix(docker-auth): pass --global to registry:login#4
Merged
Conversation
Without --global, dokku registry:login emits a deprecation warning and its positional-arg disambiguation between app-scoped and host-scoped login is implicit. The docker_auth feature's stated intent is host docker daemon login, so make the scope explicit. Updates the dry-run mask regex to skip an optional --global between registry:login and the three positionals (server/username/password), preserving back-compat for the no-flag form. Reference docs updated to show --global on both the login and logout examples.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dokku registry:loginwithout--globalworks but emits a deprecation warning, and the positional-arg disambiguation between app-scoped and host-scoped login is implicit. Thedocker_authblock's stated intent is host docker daemon login, so make the scope explicit.--globalbetweenregistry:loginand the three positionals; the no-flag form still masks correctly.--globalon both the login and logout command examples.Test plan
bun test— 229 passregistry:login --globalsilences the warning seen with the previous form