fix: halt stream on terminal AssistantMessage errors#52
Merged
Conversation
When the CLI encounters an unrecoverable error (rate limit, auth failure, billing), it enters an infinite loop emitting synthetic UserMessage/ AssistantMessage pairs. The stream never terminates because it only halts on ResultMessage. Detect AssistantMessage with a non-nil error field and synthesize a ResultMessage with is_error: true, preserving the error type as subtype and the error text as result. This ensures all existing consumers (query/2, final_text/1, collect/1) handle the error correctly. Closes #49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ResultMessage.AssistantMessagewith a non-nilerrorfield and synthesize aResultMessagewithis_error: true, preserving the error type assubtypeand the error text asresult.query/2,final_text/1,collect/1) handle the synthesized error result correctly with no changes needed.Closes #49
Test plan
RateLimitLoopAdaptersimulates 10 iterations of the rate-limit loop, asserts stream terminates with%ResultMessage{is_error: true, subtype: :rate_limit}BillingErrorAdapterverifies other error types also terminate correctlymix qualitypasses (compile, format, credo, dialyzer)