Migrate settings UI to Jetpack Compose#1711
Open
meenbeese wants to merge 2 commits into
Open
Conversation
meenbeese
force-pushed
the
settings
branch
5 times, most recently
from
58819da to
59a2566
Compare
Contributor
Author
|
This PR is ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace legacy PreferenceFragment/XML settings with a Jetpack Compose implementation. Added SettingsUi.kt (composable settings screens, dialogs and helpers), converted SettingsPreferenceFragment and SafetyPreferenceFragment to use Compose, and removed AbstractPreferenceFragment plus the old preference/layout XML files. Added ic_arrow_back drawable and updated strings/styles/theme to drop the old preferenceTheme/layout. Enabled Compose in app/build.gradle.kts and added Compose BOM + libraries to dependencies. This modernizes the settings UX and removes the old preference framework while keeping SharedPreferences as the backing store.
Also fixed a bug where the
Outbound Network Proxy (Optional)title in the toolbar was unexpectedly cut.See #1497, #1501