Skip to content

Remove some gallery-specific styling from section link #16324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SiAdcock wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove some gallery-specific styling from section link #16324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions dotcom-rendering/mise.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[tools]
node = "24"
60 changes: 21 additions & 39 deletions dotcom-rendering/src/components/SeriesSectionLink.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { css } from '@emotion/react';
import {
between,
from,
headlineBold17,
headlineBold20,
Expand Down Expand Up @@ -83,23 +82,18 @@ const marginRight = css`
}
`;

const invertedStyle = (design: ArticleDesign) => {
if (design === ArticleDesign.Gallery) {
return '';
}
return css`
/* Handle text wrapping onto a new line */
white-space: pre-wrap;
box-decoration-break: clone;
const invertedStyle = css`
/* Handle text wrapping onto a new line */
white-space: pre-wrap;
box-decoration-break: clone;
line-height: 28px;
${from.leftCol} {
line-height: 28px;
${from.leftCol} {
line-height: 28px;
}
padding-right: ${space[1]}px;
padding-top: ${space[1]}px;
padding-bottom: ${space[3]}px;
`;
};
}
padding-right: ${space[1]}px;
padding-top: ${space[1]}px;
padding-bottom: ${space[3]}px;
`;

const fontStyles = (format: ArticleFormat) => {
switch (format.design) {
Expand Down Expand Up @@ -184,26 +178,15 @@ const breakWord = css`
word-break: break-word;
`;

const sectionPadding = (design: ArticleDesign) => {
if (design === ArticleDesign.Gallery) {
return css`
padding: 0 ${space[2]}px 0 ${space[3]}px;

${between.mobileLandscape.and.tablet} {
padding-left: ${space[5]}px;
}
`;
const sectionPadding = css`
padding-left: 10px;
${from.mobileLandscape} {
padding-left: 18px;
}
return css`
padding-left: 10px;
${from.mobileLandscape} {
padding-left: 18px;
}
${from.tablet} {
padding-left: ${space[1]}px;
}
`;
};
${from.tablet} {
padding-left: ${space[1]}px;
}
`;

export const SeriesSectionLink = ({
format,
Expand Down Expand Up @@ -358,9 +341,9 @@ export const SeriesSectionLink = ({
css={[
sectionLabelLink,
fontStyles(format),
invertedStyle(format.design),
invertedStyle,
breakWord,
sectionPadding(format.design),
sectionPadding,
css`
color: ${titleColour};
background-color: ${themePalette(
Expand All @@ -369,7 +352,6 @@ export const SeriesSectionLink = ({
`,
format.design === ArticleDesign.Gallery &&
css`
display: inline-block;
position: relative;
`,
format.display === ArticleDisplay.Immersive &&
Expand Down
Loading